Return early in the Search::indexPage() method if nothing has changed #2249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
leofeyer
commented
Sep 7, 2020
leofeyer
commented
| Q | A |
|---|---|
| Fixed issues | Fixes #2235 |
| Docs PR or issue | - |
ausi
reviewed
Sep 7, 2020
Co-authored-by: Martin Auswöger <martin@auswoeger.com>
ausi
approved these changes
Sep 7, 2020
ausi
approved these changes
Sep 8, 2020
leofeyer
pushed a commit
that referenced
this pull request
Sep 8, 2020
Description ----------- | Q | A | -----------------| --- | Fixed issues | Fixes #2235 | Docs PR or issue | - Same as #2249 but for Contao 4.10. Commits ------- b669725 Skip indexing if page has not changed 200a704 Fix SQL c07379c CS e3310bb Do not cast do boolean 8f00bfb Merge branch '4.10' into fix/search-early-return
AlexejKossmann
pushed a commit
to AlexejKossmann/contao
that referenced
this pull request
Apr 6, 2021
Description ----------- | Q | A | -----------------| --- | Fixed issues | Fixes contao#2235 | Docs PR or issue | - Same as contao#2249 but for Contao 4.10. Commits ------- b669725 Skip indexing if page has not changed 200a704 Fix SQL c07379c CS e3310bb Do not cast do boolean 8f00bfb Merge branch '4.10' into fix/search-early-return
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.