Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not validate widgets that do not submit input #2261

Merged
merged 1 commit into from Sep 9, 2020
Merged

Do not validate widgets that do not submit input #2261

merged 1 commit into from Sep 9, 2020

Conversation

leofeyer
Copy link
Member

@leofeyer leofeyer commented Sep 9, 2020

Q A
Fixed issues Fixes #2210
Docs PR or issue -

@leofeyer leofeyer added the bug label Sep 9, 2020
@leofeyer leofeyer added this to the 4.10 milestone Sep 9, 2020
@leofeyer leofeyer requested a review from a team September 9, 2020 06:31
@leofeyer leofeyer self-assigned this Sep 9, 2020
@leofeyer leofeyer linked an issue Sep 9, 2020 that may be closed by this pull request
Disabled settings trigger errors upon saving #2210
Closed
@leofeyer leofeyer merged commit 4d71a92 into contao:4.10 Sep 9, 2020
@leofeyer leofeyer deleted the fix/submit-input branch September 9, 2020 07:06
@aschempp
Copy link
Member

Is there a reason this was only changed in 4.10?

@leofeyer
Copy link
Member Author

I guess we could backport the changes. Not sure about the side-effects though.

@aschempp
Copy link
Member

if it has side effects, it will have them on 4.10 too, so we need to fix them anyway 🤷

@leofeyer
Copy link
Member Author

Yes, but we should wait and see if there are any side effects in 4.10 before we also break 4.4 and 4.9. 🤷🏻‍♂️

@leofeyer leofeyer mentioned this pull request Oct 1, 2020
Closed
AlexejKossmann pushed a commit to AlexejKossmann/contao that referenced this pull request Apr 6, 2021
@leofeyer
Do not validate widgets that do not submit input (see contao#2261)
374ee45 
Description
-----------

| Q                | A
| -----------------| ---
| Fixed issues     | Fixes contao#2210
| Docs PR or issue | -

Commits
-------

2f83d0a Do not validate widgets that do not submit input
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ausi ausi ausi approved these changes

@Toflar Toflar Toflar approved these changes

Assignees

@leofeyer leofeyer

Labels
bug
Projects
None yet
Milestone
4.10
Development

Successfully merging this pull request may close these issues.

Disabled settings trigger errors upon saving
4 participants
@leofeyer @aschempp @ausi @Toflar