Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only use $dc->id in the protectFolder() method #2343

Merged
merged 1 commit into from Sep 24, 2020
Merged

Only use $dc->id in the protectFolder() method #2343

merged 1 commit into from Sep 24, 2020

Conversation

leofeyer
Copy link
Member

Q A
Fixed issues Fixes #2338
Docs PR or issue -

As discussed in Mumble on September 24th, we should not have to use the active record at all, because of:

contao/core-bundle/src/Resources/contao/drivers/DC_Folder.php

Line 2304 in 59dd103

$this->intId = $this->strPath . '/' . $varValue . $this->strExtension;

@leofeyer leofeyer requested a review from a team September 24, 2020 14:32
@leofeyer leofeyer self-assigned this Sep 24, 2020
@leofeyer leofeyer added the bug label Sep 24, 2020
@leofeyer leofeyer added this to the 4.9 milestone Sep 24, 2020
@leofeyer leofeyer linked an issue Sep 24, 2020 that may be closed by this pull request
Cannot create new folders in the file manager #2338
Closed
@leofeyer leofeyer merged commit 25acd09 into contao:4.9 Sep 24, 2020
@leofeyer leofeyer deleted the fix/protect-folder branch September 24, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ausi ausi ausi approved these changes

@bytehead bytehead bytehead approved these changes

Assignees

@leofeyer leofeyer

Labels
bug
Projects
None yet
Milestone
4.9
Development

Successfully merging this pull request may close these issues.

Cannot create new folders in the file manager
3 participants
@leofeyer @ausi @bytehead