Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly check for numeric page IDs #2369

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Correctly check for numeric page IDs #2369

merged 1 commit into from
Sep 28, 2020

Conversation

aschempp
Copy link
Member

Fixes #2306, replaces #2361 (review)

@aschempp aschempp added the bug label Sep 28, 2020
@aschempp aschempp added this to the 4.9 milestone Sep 28, 2020
@aschempp aschempp requested a review from a team September 28, 2020 09:35
@aschempp aschempp self-assigned this Sep 28, 2020
@ausi
Copy link
Member

ausi commented Sep 28, 2020

replaces #2361 (review)

I don’t think it replaces it. IMO both PRs should get merged.

@leofeyer leofeyer merged commit 47f4d21 into contao:4.9 Sep 28, 2020
@aschempp aschempp deleted the bugfix/numeric-alias branch October 20, 2020 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aschempp aschempp

Labels
bug
Projects
None yet
Milestone
4.9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aschempp @ausi @leofeyer