Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove existing tags from annotations that could be arrays #2372

Merged
merged 2 commits into from
Oct 6, 2020

Conversation

aschempp
Copy link
Member

@aschempp aschempp commented Sep 29, 2020

Fixes #2371

Let's see what symfony/symfony#38339 brings up …

@aschempp aschempp added the bug label Sep 29, 2020
@aschempp aschempp added this to the 4.10 milestone Sep 29, 2020
@aschempp aschempp requested review from fritzmg and a team September 29, 2020 07:30
@aschempp aschempp self-assigned this Sep 29, 2020
@leofeyer leofeyer linked an issue Sep 29, 2020 that may be closed by this pull request
@aschempp aschempp marked this pull request as ready for review October 6, 2020 04:55
@aschempp
Copy link
Member Author

aschempp commented Oct 6, 2020

I think we should merge this regardless of Symfony, otherwise page controllers are not really useable.

@leofeyer leofeyer merged commit f7c15c0 into contao:4.10 Oct 6, 2020
@aschempp aschempp deleted the bugfix/page-annotation branch October 10, 2020 14:56
AlexejKossmann pushed a commit to AlexejKossmann/contao that referenced this pull request Apr 6, 2021
…o#2372)

Description
-----------

Fixes contao#2371

Let's see what symfony/symfony#38339 bringts up …

Commits
-------

7a35efc Remove existing tags from annotations that could  be arrays
de60bb6 Page type is optional, it's automatically generated in the compiler pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page Annotation does not work
3 participants