Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use meaningful values for the "autocomplete" attributes #2432

Merged
merged 2 commits into from Oct 16, 2020
Merged

Use meaningful values for the "autocomplete" attributes #2432

merged 2 commits into from Oct 16, 2020

Conversation

leofeyer
Copy link
Member

Implements #1669

@leofeyer leofeyer added this to the 4.11 milestone Oct 15, 2020
@leofeyer leofeyer requested a review from a team October 15, 2020 15:10
@leofeyer leofeyer self-assigned this Oct 15, 2020
@leofeyer leofeyer linked an issue Oct 15, 2020 that may be closed by this pull request
Set helpful values to autocomplete attribute in user context #1669
Closed
bytehead
bytehead previously approved these changes Oct 15, 2020
View reviewed changes
@leofeyer leofeyer requested a review from a team October 15, 2020 15:24
@leofeyer leofeyer mentioned this pull request Oct 16, 2020
Merged
@leofeyer leofeyer merged commit 95ed373 into contao:master Oct 16, 2020
@leofeyer leofeyer deleted the feature/autocomplete branch October 16, 2020 10:52
AlexejKossmann pushed a commit to AlexejKossmann/contao that referenced this pull request Apr 6, 2021
@leofeyer
Use meaningful values for the "autocomplete" attributes (see contao#2432
8573b4b 
)

Description
-----------

Implements contao#1669

Commits
-------

8be1dd9 Use meaningful values for the "autocomplete" attributes
50e6924 Found more occurrences
@leofeyer leofeyer mentioned this pull request Apr 26, 2021
Merged
leofeyer added a commit that referenced this pull request Apr 26, 2021
@leofeyer
Backport the autocomplete changes (see #2973)
2e762a3 
Description
-----------

This PR backports the changes from #2432. I consider this a bugfix, because password managers like 1password no longer work properly without the correct attributes (especially not with `autocomplete="off"`).

Commits
-------

fad6c6b Backport the autocomplete changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschempp aschempp aschempp left review comments

@asaage asaage asaage left review comments

@bytehead bytehead bytehead approved these changes

@fritzmg fritzmg fritzmg approved these changes

Assignees

@leofeyer leofeyer

Labels
feature
Projects
None yet
Milestone
4.11
Development

Successfully merging this pull request may close these issues.

Set helpful values to autocomplete attribute in user context
5 participants
@leofeyer @bytehead @aschempp @asaage @fritzmg