Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RTM] Deferred image resizing #354

Merged
merged 49 commits into from Jun 21, 2019
Merged

[RTM] Deferred image resizing #354

Changes from 1 commit
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
29a4a64
Add deferred image resizing
ausi Feb 18, 2019
539475d
Fix issues with deferred images
ausi Feb 19, 2019
e0efdca
Fix tests
ausi Feb 19, 2019
4146dcb
Use getDeferredImage instead of file exists check
ausi Feb 19, 2019
1716b3c
Coding style
ausi Feb 19, 2019
979dfa3
Add route dynamically
ausi Feb 19, 2019
fb5a765
Handle deferred images in the image factory
ausi Feb 19, 2019
974632d
Fix database requests
ausi Feb 19, 2019
247be93
Use invoke instead of an action method
ausi Feb 19, 2019
5649110
Fix the coding style
leofeyer Feb 19, 2019
6ef859f
Fix controller name
ausi Feb 19, 2019
1a519b2
Use contao/image 1.0.0
ausi Feb 19, 2019
668b19b
Fix type issues
ausi Feb 20, 2019
e697880
Adapt to new ImportantPart implementation
ausi Feb 20, 2019
6c6cab7
Add deferred-images command
ausi Mar 16, 2019
1c03e60
Coding style
ausi Mar 16, 2019
f785164
Fix error output
ausi Mar 16, 2019
259612a
Store important part coordinates as fractions
ausi Mar 16, 2019
e67b127
Fix tests
ausi Mar 16, 2019
2fd1c11
Use imageViewSize instead of imageSize
ausi Mar 18, 2019
2e61c90
Inlined requirements are not supported in Symfony 3.4
ausi Mar 18, 2019
45a2f54
Rename command to resize-images
ausi Mar 18, 2019
feae4f3
Fix PHPStan issues
ausi Mar 21, 2019
1a48c09
Fix wrong parameter signature
ausi Mar 21, 2019
0bcdc86
Make filesystem parameter optional
ausi Jun 16, 2019
98384c9
Reorder routing configuration
ausi Jun 16, 2019
12761e4
Add cache headers to image responses
ausi Jun 16, 2019
52fb9f9
Fix PHPStan issues
ausi Jun 16, 2019
78692cf
Fix mixed-up variable
ausi Jun 16, 2019
afa03b9
Test resize images command
ausi Jun 16, 2019
a0711b7
Test image factory with deferred image
ausi Jun 16, 2019
b39b1a9
Test images route loader
ausi Jun 16, 2019
163330e
Test images controller
ausi Jun 16, 2019
6483849
Use 1.0.0-beta1 version of contao/image
ausi Jun 16, 2019
ecfaff2
Fix cache headers
ausi Jun 17, 2019
b345016
Test cache headers
ausi Jun 17, 2019
574ea80
Synchronize composer.json
ausi Jun 17, 2019
4211187
Check if image exists before returning a reponse
ausi Jun 17, 2019
327e353
Use single quotes
ausi Jun 17, 2019
275574d
Use unsigned columns to store the important part
ausi Jun 17, 2019
b3ac722
Only check one column for the 4.8 database update
ausi Jun 17, 2019
4087595
Improve readability
ausi Jun 18, 2019
68c595b
Cast concurrent parameter to integer directly
ausi Jun 18, 2019
4fa47a7
Improve readability
ausi Jun 18, 2019
cc47887
Throw exception if framework is not initialized
ausi Jun 20, 2019
28f2060
Fix tests
ausi Jun 20, 2019
1e592eb
Fix some minor CS issues
leofeyer Jun 21, 2019
7d036d5
Add comment
ausi Jun 21, 2019
13419c3
Rename service ID to match class name
ausi Jun 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion core-bundle/src/Controller/ImagesController.php
View file
Open in desktop
Expand Up @@ -60,6 +60,6 @@ public function __invoke(string $path): Response
throw new NotFoundHttpException($exception->getMessage(), $exception);
}

return new BinaryFileResponse($image->getPath());
return new BinaryFileResponse($image->getPath(), 200, ['Cache-Control' => 'maxage=31536000']);
ausi marked this conversation as resolved.
Show resolved Hide resolved
}
}