Fix infinite loop while loading of languages #4254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leofeyer
approved these changes
Mar 14, 2022
|
Thank you @rabauss. |
leofeyer
added a commit
that referenced
this pull request
Mar 20, 2024
Description ----------- Fixes #3803, #4254, ... Something bad happened to me recently. I had a mailcious migration that did run forever. Because the migration was triggered by CI/CD, I had no control in stopping it... 馃檧 IMHO, there is no legitamte case (esp in prodution) where migrations need to run more than (lets say a random number) eight times. Therefore, this PR adds a maximum loop count. This PR fixes a range of potential errors, incl. concrete errors (see issue numbers above). (We might also consider to break the loop and return a command failure code). Commits ------- 6cc2c91 Add loop control for migrations c06528c Introduce local variable 5f3e30e Stop with error 8698970 Also write NDJSON 07fb02e Increase maximum iterations ad0dd71 Update MigrateCommand.php e453142 Update MigrateCommand.php a6fd497 Adjust the error message Co-authored-by: leofeyer <1192057+leofeyer@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When upgrading to Contao 4.13 I got an infinite loop on all pages that loaded the languages with
System::getLanguages().The problem was, that my backend user had the legacy language
de_DE- but I only realized that after the long analysis of this issue. And you cannot change the language because the backend profile page will also end up in an infinite loop 馃槩By the way maybe an migration of the backend language of the users could make sense.
But it will also break the frontend if you use a non 2-letter language and have a frontend element which calls
contao.intl.locales馃憖Because of #4043 the method
getLocalesis recursively called while loading the language files.But the language is shortend shortly before in
loadLanguageFileso you will get an infinite loop because of different$strCacheKeycontao/core-bundle/src/Resources/contao/library/Contao/System.php
Line 502 in af3d72d