Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite the Backend.limitPreviewHeight to vanilla JS #4342

Merged
merged 7 commits into from Mar 30, 2022
Merged

Rewrite the Backend.limitPreviewHeight to vanilla JS #4342

merged 7 commits into from Mar 30, 2022

Conversation

aschempp
Copy link
Member

@aschempp aschempp commented Mar 21, 2022 •
edited

The new combiner is intentional since the script is not used in any of the other backend templates.

@aschempp aschempp added this to the 5.0 milestone Mar 21, 2022
@aschempp aschempp requested a review from a team March 21, 2022 23:25
@aschempp aschempp self-assigned this Mar 21, 2022
@aschempp aschempp mentioned this pull request Mar 22, 2022
Merged
ausi
ausi reviewed Mar 22, 2022
View reviewed changes
.editorconfig Outdated Show resolved Hide resolved
@leofeyer leofeyer mentioned this pull request Mar 22, 2022
Merged
leofeyer added a commit that referenced this pull request Mar 22, 2022
@leofeyer
Templates should end with an empty line (see #4360)
fd122af 
Description
-----------

In preparation of #4342.

Commits
-------

0390270 Templates should end with an empty line
@aschempp aschempp requested a review from ausi March 22, 2022 17:05
@leofeyer leofeyer merged commit e8ca61c into contao:5.x Mar 30, 2022
@aschempp aschempp deleted the feature/vanilla1 branch March 31, 2022 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Toflar Toflar Toflar left review comments

@ausi ausi ausi approved these changes

@leofeyer leofeyer leofeyer approved these changes

Assignees

@aschempp aschempp

Labels
feature
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aschempp @ausi @Toflar @leofeyer