Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the global state unit tests #4618

Merged
merged 3 commits into from
May 9, 2022
Merged

Conversation

leofeyer
Copy link
Member

@leofeyer leofeyer commented May 6, 2022

This should fix https://github.com/contao/contao/runs/6307113827?check_suite_focus=true. Note that the job is only run periodically, so even if the CI chain below is green, the tests might still fail. Run vendor/bin/phpunit --extensions Contao\\CoreBundle\\Tests\\PhpunitExtension\\GlobalStateWatcher on the CLI to verify.

@leofeyer leofeyer added the CI label May 6, 2022
@leofeyer leofeyer added this to the 5.0 milestone May 6, 2022
@leofeyer leofeyer self-assigned this May 6, 2022
@leofeyer leofeyer requested a review from ausi May 6, 2022 10:34
ausi added a commit to ausi/contao-contao that referenced this pull request May 7, 2022
@ausi ausi mentioned this pull request May 7, 2022
@leofeyer leofeyer requested a review from ausi May 9, 2022 10:26
@leofeyer leofeyer merged commit 222f391 into contao:5.x May 9, 2022
@leofeyer leofeyer deleted the fix/global-state branch May 9, 2022 15:38
leofeyer added a commit to contao/test-case that referenced this pull request May 9, 2022
Description
-----------

-

Commits
-------

32306fab Fix the global state unit tests
4405ac88 Suggestions for contao/contao#4618 (#4)

Co-authored-by: Martin Auswöger <martin@auswoeger.com>
leofeyer added a commit to contao/calendar-bundle that referenced this pull request May 9, 2022
Description
-----------

-

Commits
-------

32306fab Fix the global state unit tests
4405ac88 Suggestions for contao/contao#4618 (#4)

Co-authored-by: Martin Auswöger <martin@auswoeger.com>
leofeyer added a commit to contao/core-bundle that referenced this pull request May 9, 2022
Description
-----------

-

Commits
-------

32306fab Fix the global state unit tests
4405ac88 Suggestions for contao/contao#4618 (#4)

Co-authored-by: Martin Auswöger <martin@auswoeger.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants