Drop support for an empty tl_content.ptable column
#4653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am in favour of migrating empty to |
|
Yes, migration! |
m-vo
previously approved these changes
May 11, 2022
ausi
previously approved these changes
May 11, 2022
|
Migration added in f9a9e21. |
m-vo
previously approved these changes
May 11, 2022
fritzmg
previously approved these changes
May 11, 2022
Co-authored-by: Martin Auswöger <martin@auswoeger.com>
m-vo
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@contao/developers What do you think about adding a migration that automatically changes empty columns to
tl_article?I‘m not sure if that would be too destructive. On the other hand, an empty column is treated as
tl_articlein Contao 4, so the value cannot really have a different meaning, can it?