[WIP] Force inline renderer if request contains cookies #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should only rewrite the |
|
Yeah I was thinking the same but should be good enough for some tests. |
|
We just discussed this again and we're not sure this is the correct solution. The solution might work as a side effect because rememberme is a cookie. But the correct solution would probably be to force a browser reload after a rememberme login, so the actual request contains the session cookie. |
|
Still discussing: Nope, this is not the solution either. Guess we need yet another conference call regarding the cache. |
leofeyer
added
the
up for discussion
leofeyer
removed
the
up for discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation and tests follow, this is just a quick POC.