Correctly add the preview script

[leofeyer]

If Contao runs in a subfolder (which we allow locally), the /preview.php fragment will be added incorrectly.

URL: https://domain.wip/managed-edition/public/contao/preview
Before: https://domain.wip/preview.php/managed-edition/public/contao/preview
After: https://domain.wip/managed-edition/public/preview.php/contao/preview

[aschempp]

what about all the other places, like PageModell::getPreviewUrl()?

also, should it ever be possible to set a preview script that includes a subfolder/path? Or maybe we should add a validation for that?

also, this seems to assume the default entry point is never called with a script, or am I reading this wrong?

[leofeyer]

what about all the other places, like PageModell::getPreviewUrl()?

They were not affected in my tests, probably because we are using the UrlGenerator with a custom context there instead of the request object.

[qzminski]

It look like that after this commit, the frontend preview URLs like https://domain.tld/contao/preview?page=6 no longer work. What happens is that the user is redirected to the https://domain.tld/preview.php/contao/preview (notice missing query parameters) and the frontend preview always shows the homepage.

I think the fix would be:

-return new RedirectResponse($request->getBasePath().$this->previewScript.$request->getPathInfo());
+return new RedirectResponse($request->getBasePath().$this->previewScript.$request->getPathInfo().($request->getQueryString() ? ('?' . $request->getQueryString()) : ''));

But I am not completely sure.

[Toflar]

Looks correct to me. Would you be so kind to create a PR? I think to show the problem it should be sufficient to add a query to any of the tests ;)

[qzminski]

See #4891