Cache index default length per table engine in DcaSchemaProvider #4860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bezin
force-pushed
the
cache-values-per-engine
branch
from
037fb7b
to
ff71b14
Compare
|
Duplicate of #4853 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When in
devmode (without warming the cache first), I noticed that when I open the back end dashboard, the database is queried 224 times. 172 queries of these areSHOW VARIABLES LIKE 'innodb_large_prefix'andSELECT @@version(88 times each) making up for about 83 % of the total time spent on database queries. With this PR the index default length is cached per engine inDcaSchemaProvider, so these queries are only run once per engine.