New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the installer into the core #4888
Move the installer into the core #4888
Conversation
Co-authored-by: Yanick Witschi <yanick.witschi@terminal42.ch>
Two questions:
|
…/contao into remove-migrations-from-install-tool
Don’t think so, this stuff is all needed, isn’t it? |
The install bundle will not work anymore without the removed command grouping logic. |
Co-authored-by: Fritz Michael Gschwantner <fmg@inspiredminds.at>
I readded the ability to distinguish between all schema updates + those that remove columns in b12d4ab. We're now effectively copying the columns that should be remove to the |
…/contao into remove-migrations-from-install-tool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Thank you @m-vo. |
This PR moves the
Installer
into the core bundle and removes the ability to run migrations from the install tool.With this change, also both the
sqlCompileCommands
hook as well as the parsing and grouping of SQL commands is removed. The order and command grouping now matches the output of doctrine's schema diff (which finally solves #2792 (comment)).The first commit (1406bc3) is only about moving things around without changing the implementation - to get a better idea about the actual code changes, you might want to base your diff view on this commit.
/cc @ausi