Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the installer into the core #4888

Merged
merged 17 commits into from Jun 28, 2022

Conversation

m-vo
Copy link
Member

@m-vo m-vo commented Jun 27, 2022

This PR moves the Installer into the core bundle and removes the ability to run migrations from the install tool.

With this change, also both the sqlCompileCommands hook as well as the parsing and grouping of SQL commands is removed. The order and command grouping now matches the output of doctrine's schema diff (which finally solves #2792 (comment)).

The first commit (1406bc3) is only about moving things around without changing the implementation - to get a better idea about the actual code changes, you might want to base your diff view on this commit.

/cc @ausi

@m-vo m-vo added this to the 5.0 milestone Jun 27, 2022
@m-vo m-vo self-assigned this Jun 27, 2022
UPGRADE.md Outdated Show resolved Hide resolved
Co-authored-by: Yanick Witschi <yanick.witschi@terminal42.ch>
@aschempp
Copy link
Member

Two questions:

  1. any particular reason we're not just moving the existing classes to the core-bundle and keep everything as is, since I assume we want to get rid of all this stuff anyway?
  2. any reason to remove stuff from the installation bundle? I mean shouldn't we just remove the installation-bundle from contao/contao in one PR?

@ausi
Copy link
Member

ausi commented Jun 28, 2022

since I assume we want to get rid of all this stuff anyway?

Don’t think so, this stuff is all needed, isn’t it?

@m-vo
Copy link
Member Author

m-vo commented Jun 28, 2022

any reason to remove stuff from the installation bundle?

The install bundle will not work anymore without the removed command grouping logic.

UPGRADE.md Outdated Show resolved Hide resolved
m-vo and others added 2 commits June 28, 2022 12:04
Co-authored-by: Fritz Michael Gschwantner <fmg@inspiredminds.at>
@m-vo
Copy link
Member Author

m-vo commented Jun 28, 2022

I readded the ability to distinguish between all schema updates + those that remove columns in b12d4ab. We're now effectively copying the columns that should be remove to the $toSchema which makes them disappear in the diff.

ausi
ausi previously approved these changes Jun 28, 2022
Copy link
Member

@ausi ausi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@leofeyer leofeyer merged commit 25e9a50 into contao:5.x Jun 28, 2022
@leofeyer
Copy link
Member

Thank you @m-vo.

@leofeyer leofeyer changed the title Move installer into the core Move the installer into the core Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants