Backport lazy services for CronJob repository #5072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fritzmg
previously approved these changes
Aug 3, 2022
|
Test are failing… |
|
Failing prefer-lowest tests seem unrelated |
|
hmmm… or maybe not, maybe the lower allowed does not support |
|
looks like this was fixed in Symfony 4.4.23 only (symfony/symfony@1aa9a24). Not sure if we can raise our minimum dependency of the symfony/dependency-injection component? |
Why not? Currently we require |
leofeyer
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow #4265 only made it into 4.13 even though the same problem exists in the current 4.9 version. Running
contao-console list --format=jsonresults in a database exception.