Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow null query on unique fields and implement early return #5097

Merged
merged 3 commits into from Aug 8, 2022
Merged

Allow null query on unique fields and implement early return #5097

merged 3 commits into from Aug 8, 2022

Conversation

fritzmg
Copy link
Contributor

@fritzmg fritzmg commented Aug 8, 2022 •
edited

Fixes #5033

This will allow null for any findBy('id', …), findByPk(…) etc. calls again while also implementing an early return.

I'll create separate PRs for 4.9 and 4.13.

@fritzmg fritzmg added the bug label Aug 8, 2022
@fritzmg fritzmg added this to the 5.0 milestone Aug 8, 2022
@fritzmg fritzmg requested a review from ausi August 8, 2022 09:22
@fritzmg fritzmg self-assigned this Aug 8, 2022
@leofeyer leofeyer merged commit 31633a3 into contao:5.0 Aug 8, 2022
@leofeyer
Copy link
Member

leofeyer commented Aug 8, 2022

Thank you @fritzmg.

@ausi ausi mentioned this pull request Aug 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ausi ausi ausi approved these changes

Assignees

@fritzmg fritzmg

Labels
bug
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fritzmg @leofeyer @ausi