Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the sitemap cache invalidation in the news module #5326

Merged

Conversation

qzminski
Copy link
Member

I don't have an exact way of reproducing this, yet Sentry caught this a few times:

CleanShot 2022-09-29 at 12 21 29

@github-actions github-actions bot added this to the 4.13 milestone Sep 29, 2022
@github-actions github-actions bot added the bug label Sep 29, 2022
@fritzmg
Copy link
Contributor

fritzmg commented Sep 29, 2022

Can you provide the full stack trace + the URL logged by Sentry under which this error occurred?

@qzminski
Copy link
Member Author

URL:

https://domain.tld/contao?do=news&id=38&ref=lcZQVNkv&revise=tl_news.950&rt=1091c11cf2f44709a4d605a5896cdc.3SiGWfAh-gaq5HzgLgrMeeKfLM5yuzQDZhcvwebxC-U.jRHiEIZQmDfgqgbQZT-NO4rNZ5wozQFuB3Jsr5bISYGyefESnEKycvKoMQ&table=tl_news

Stacktrace:

ErrorException: Warning: Attempt to read property "jumpTo" on null
#18 /var/cache/prod/contao/dca/tl_news.php(346): tl_news::addSitemapCacheInvalidationTag
#17 /vendor/contao/core-bundle/src/Resources/contao/classes/DataContainer.php(1502): Contao\DataContainer::invalidateCacheTags
#16 /vendor/contao/core-bundle/src/Resources/contao/drivers/DC_Table.php(3458): Contao\DC_Table::reviseTable
#15 /vendor/contao/core-bundle/src/Resources/contao/drivers/DC_Table.php(257): Contao\DC_Table::showAll
#14 /vendor/contao/core-bundle/src/Resources/contao/classes/Backend.php(667): Contao\Backend::getBackendModule
#13 /vendor/contao/core-bundle/src/Resources/contao/controllers/BackendMain.php(168): Contao\BackendMain::run
#12 /vendor/contao/core-bundle/src/Controller/BackendController.php(49): Contao\CoreBundle\Controller\BackendController::mainAction
#11 /vendor/symfony/http-kernel/HttpKernel.php(152): Symfony\Component\HttpKernel\HttpKernel::handleRaw
#10 /vendor/symfony/http-kernel/HttpKernel.php(74): Symfony\Component\HttpKernel\HttpKernel::handle
#9 /vendor/symfony/http-kernel/Kernel.php(202): Symfony\Component\HttpKernel\Kernel::handle
#8 /vendor/symfony/http-kernel/HttpCache/SubRequestHandler.php(86): Symfony\Component\HttpKernel\HttpCache\SubRequestHandler::handle
#7 /vendor/symfony/http-kernel/HttpCache/HttpCache.php(479): Symfony\Component\HttpKernel\HttpCache\HttpCache::forward
#6 /vendor/symfony/framework-bundle/HttpCache/HttpCache.php(73): Symfony\Bundle\FrameworkBundle\HttpCache\HttpCache::forward
#5 /vendor/symfony/http-kernel/HttpCache/HttpCache.php(452): Symfony\Component\HttpKernel\HttpCache\HttpCache::fetch
#4 /vendor/contao/manager-bundle/src/HttpKernel/ContaoCache.php(66): Contao\ManagerBundle\HttpKernel\ContaoCache::fetch
#3 /vendor/symfony/http-kernel/HttpCache/HttpCache.php(346): Symfony\Component\HttpKernel\HttpCache\HttpCache::lookup
#2 /vendor/symfony/http-kernel/HttpCache/HttpCache.php(224): Symfony\Component\HttpKernel\HttpCache\HttpCache::handle
#1 /vendor/friendsofsymfony/http-cache/src/SymfonyCache/EventDispatchingHttpCache.php(98): Contao\ManagerBundle\HttpKernel\ContaoCache::handle
#0 /web/index.php(44): null

@leofeyer leofeyer requested a review from a team October 6, 2022 13:41
@leofeyer leofeyer changed the title Fix a potential error if the news archive model is not found in sitemap cache invalidation tag helper Fix the sitemap cache invalidation in the news module Oct 6, 2022
@leofeyer leofeyer merged commit cddd991 into contao:4.13 Oct 6, 2022
@leofeyer
Copy link
Member

leofeyer commented Oct 6, 2022

Thank you @qzminski.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants