Read column types from database if cache is missing #5428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 25, 2022
|
I definitely like this better than #5349. 👍 |
m-vo
previously approved these changes
Nov 12, 2022
leofeyer
reviewed
Nov 14, 2022
leofeyer
approved these changes
Nov 15, 2022
|
Thank you @ausi. |
|
can we use this for Widget::getDefault/empty value as well? |
IMO yes, extending this with the required information should work fine. Can you create a new ticket for that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #5349
Fixes #5029 (comment)
In debug mode, or when the type cache is missing, we now retrieve the type information directly from the database instead of loading all DCAs.
The cache warmer still uses the information from the DCA, because the database might not be up to date when warming the cache.