Update the tools

core-bundle/contao/library/Contao/Input.php

@@ -480,6 +480,8 @@ public static function setUnusedRouteParameters(array $routeParameters): void
 	 *
 	 * @see FrontendTemplate::compile()
 	 *
+	 * @phpstan-impure
+	 *
 	 * @return list<string>
 	 */
 	public static function getUnusedRouteParameters(): array

core-bundle/src/Controller/ContentElement/MarkdownController.php

@@ -36,6 +36,15 @@
 #[AsContentElement(category: 'texts')]
 class MarkdownController extends AbstractContentElementController
 {
+    public static function getSubscribedServices(): array
+    {
+        $services = parent::getSubscribedServices();
+
+        $services['contao.insert_tag.parser'] = InsertTagParser::class;
+
+        return $services;
+    }
+
     protected function getResponse(Template $template, ContentModel $model, Request $request): Response
     {
         $this->initializeContaoFramework();
@@ -115,13 +124,4 @@ private function getContentFromFile(string|null $file): string
 
         return (string) file_get_contents($path);
     }
-
-    public static function getSubscribedServices(): array
-    {
-        $services = parent::getSubscribedServices();
-
-        $services['contao.insert_tag.parser'] = InsertTagParser::class;
-
-        return $services;
-    }
 }

core-bundle/src/Migration/CommandCompiler.php

@@ -33,9 +33,15 @@ public function __construct(private readonly Connection $connection, private rea
     public function compileCommands(bool $skipDropStatements = false): array
     {
         $schemaManager = $this->connection->createSchemaManager();
-        $fromSchema = $schemaManager->createSchema();
         $toSchema = $this->schemaProvider->createSchema();
 
+        // Backwards compatibility with doctrine/dbal < 3.5
+        if (method_exists($schemaManager, 'introspectSchema')) {
+            $fromSchema = $schemaManager->introspectSchema();
+        } else {
+            $fromSchema = $schemaManager->createSchema();
+        }
+
         // If tables or columns should be preserved, we copy the missing
         // definitions over to the $toSchema, so that no DROP commands
         // will be issued in the diff.

core-bundle/tests/Controller/ContentElement/MarkdownControllerTest.php

@@ -137,6 +137,29 @@ public function testWithFileInput(): void
         $fs->remove($tempTestFile);
     }
 
+    public function testOutputsMarkdownAsHtml(): void
+    {
+        $response = $this->renderWithModelData(
+            new MarkdownController(),
+            [
+                'type' => 'markdown',
+                'code' => "## Headline\n * my\n * list",
+            ]
+        );
+
+        $expectedOutput = <<<'HTML'
+            <div class="content-markdown">
+                <h2>Headline</h2>
+                    <ul>
+                        <li>my</li>
+                        <li>list</li>
+                    </ul>
+                </div>
+            HTML;
+
+        $this->assertSameHtml($expectedOutput, $response->getContent());
+    }
+
     private function mockContainer(string $expectedMarkdown, array $frameworkAdapters = []): Container
     {
         $template = $this->createMock(FrontendTemplate::class);
@@ -176,27 +199,4 @@ private function mockContainer(string $expectedMarkdown, array $frameworkAdapter
 
         return $container;
     }
-
-    public function testOutputsMarkdownAsHtml(): void
-    {
-        $response = $this->renderWithModelData(
-            new MarkdownController(),
-            [
-                'type' => 'markdown',
-                'code' => "## Headline\n * my\n * list",
-            ]
-        );
-
-        $expectedOutput = <<<'HTML'
-            <div class="content-markdown">
-                <h2>Headline</h2>
-                    <ul>
-                        <li>my</li>
-                        <li>list</li>
-                    </ul>
-                </div>
-            HTML;
-
-        $this->assertSameHtml($expectedOutput, $response->getContent());
-    }
 }

core-bundle/tests/Migration/CommandCompilerTest.php

@@ -495,7 +495,8 @@ private function getInstaller(Schema $fromSchema = null, Schema $toSchema = null
 
         $schemaManager = $this->createMock(MySQLSchemaManager::class);
         $schemaManager
-            ->method('createSchema')
+            // Backwards compatibility with doctrine/dbal < 3.5
+            ->method(method_exists($schemaManager, 'introspectSchema') ? 'introspectSchema' : 'createSchema')
             ->willReturn($fromSchema)
         ;
 

core-bundle/tests/Monolog/ContaoTableProcessorTest.php

@@ -32,11 +32,6 @@ public function testCanBeInvoked(): void
     {
         $processor = $this->getContaoTableProcessor();
 
-        /** @phpstan-var Record $record */
-        $record = [];
-
-        $this->assertEmpty($processor($record));
-
         $record = [
             'message' => '',
             'context' => ['contao' => false],

phpstan.neon

@@ -31,6 +31,26 @@ parameters:
             message: '#type array<Symfony\\Component\\HttpKernel\\Fragment\\FragmentRendererInterface> is incompatible with native type Psr\\Container\\ContainerInterface#'
             path: %currentWorkingDirectory%/core-bundle/src/Fragment/FragmentHandler.php
 
+        -
+            # Ignore global operations in the DefaultOperationsListenerTest class
+            message: "#Call to method PHPUnit\\\\Framework\\\\Assert::assertArrayHasKey\\(\\) with 'operations' and array\\{sorting: .+\\}\\} will always evaluate to false\\.#"
+            path: %currentWorkingDirectory%/core-bundle/tests/EventListener/DataContainer/DefaultOperationsListenerTest.php
+
+        -
+            # Ignore global operations in the PreviewLinkListenerTest class
+            message: '#Call to method PHPUnit\\Framework\\Assert::assertFalse\(\) with true will always evaluate to false\.#'
+            path: %currentWorkingDirectory%/core-bundle/tests/EventListener/DataContainer/PreviewLinkListenerTest.php
+
+        -
+            # Ignore global operations in the ContaoFrameworkTest class
+            message: "#Call to method PHPUnit\\\\Framework\\\\Assert::assertSame\\(\\) with array\\{array\\{'test.listener.+\\}\\} and mixed will always evaluate to false\\.#"
+            path: %currentWorkingDirectory%/core-bundle/tests/Framework/ContaoFrameworkTest.php
+
+        -
+            # Ignore undetected changes in the cache adpater after persisting data
+            message: '#Call to method PHPUnit\\Framework\\Assert::assertNotEmpty\(\) with array\{\} will always evaluate to false\.#'
+            path: %currentWorkingDirectory%/core-bundle/tests/Twig/Loader/ContaoFilesystemLoaderTest.php
+
         # Ignore the wrong return type hint of the UrlGeneratorInterface::generate() method
         - '#Method Contao\\CoreBundle\\Picker\\AbstractPickerProvider::generateUrl\(\) never returns null so it can be removed from the return type\.#'