Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile navigation row via own method #581

Merged
merged 3 commits into from
Jan 3, 2020
Merged

Compile navigation row via own method #581

merged 3 commits into from
Jan 3, 2020

Conversation

rabauss
Copy link
Contributor

@rabauss rabauss commented Jul 14, 2019

Compile navigation row via own method, to get the possibility to overwrite/extend it in own extensions.

@leofeyer leofeyer added this to the 4.9 milestone Jul 23, 2019
@aschempp
Copy link
Member

The PR generally looks good to me. I just dislike the whole navigation module concept because
a. it is inside the parent Module class
b. it does not use the knp/menu-bundle
c. its hell of ugly code…

@rabauss why are you using these methods anyway? Are you overriding the navigation module or creating a second one?

@rabauss
Copy link
Contributor Author

rabauss commented Jul 24, 2019

The Code is really a ugly.
But in one project we used or overwritten this module. Finally, we could have written the module ourselves.
I just wanted to give the oportunity to do easier overwrites in the future ;-)

@Toflar
Copy link
Member

Toflar commented Jul 24, 2019

I‘m fine with that change. Doesn‘t do any harm😊

ausi
ausi previously approved these changes Jul 24, 2019
@leofeyer
Copy link
Member

It seems this PR needs some rebasing. 🙈

@leofeyer
Copy link
Member

leofeyer commented Jan 2, 2020

Contao 4.9 is now in the review phase in which we try to review and merge the remaining pull requests that have been created during the development phase. Your pull request does not yet meet the requirements to be reviewed though:

  • Make sure that the PR is feature complete.
  • Rebase the PR onto the latest master branch.
  • Address the requested changes if any.
  • Make sure that all CI checks are successful.

Please fix this soon if you can, because the review phase ends on January 15th and we need some time to review the PR before we can merge it.

Co-Authored-By: Leo Feyer <github@contao.org>
@leofeyer leofeyer merged commit 8b88532 into contao:master Jan 3, 2020
@leofeyer
Copy link
Member

leofeyer commented Jan 3, 2020

Thank you @rabauss.

@rabauss rabauss deleted the feature/navigation branch January 9, 2020 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants