-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile navigation row via own method #581
Conversation
The PR generally looks good to me. I just dislike the whole navigation module concept because @rabauss why are you using these methods anyway? Are you overriding the navigation module or creating a second one? |
The Code is really a ugly. |
I‘m fine with that change. Doesn‘t do any harm😊 |
It seems this PR needs some rebasing. 🙈 |
Contao 4.9 is now in the review phase in which we try to review and merge the remaining pull requests that have been created during the development phase. Your pull request does not yet meet the requirements to be reviewed though:
Please fix this soon if you can, because the review phase ends on January 15th and we need some time to review the PR before we can merge it. |
Co-Authored-By: Leo Feyer <github@contao.org>
Thank you @rabauss. |
Compile navigation row via own method, to get the possibility to overwrite/extend it in own extensions.