Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh the cache after updating metadata in the Dbafs class #5834

Merged
merged 3 commits into from Mar 6, 2023

Conversation

Toflar
Copy link
Member

@Toflar Toflar commented Mar 2, 2023

The cache means that currently, setting and retrieving meta data right away in the same request, does not work.
Reproducer:

$this->filesystem->setExtraMetadata($uuid, ['foobar' => 'foo']);
$item = $this->filesystem->get($uuid); // $item will not have 'foobar' data available

@Toflar Toflar added the bug label Mar 2, 2023
@Toflar Toflar added this to the 4.13 milestone Mar 2, 2023
@Toflar Toflar requested a review from m-vo March 2, 2023 12:40
@Toflar Toflar self-assigned this Mar 2, 2023
@Toflar
Copy link
Member Author

Toflar commented Mar 2, 2023

Failing tests unrelated.

core-bundle/src/Filesystem/Dbafs/Dbafs.php Outdated Show resolved Hide resolved
@Toflar Toflar changed the title Fixed Dbafs not clearing records cache after metadata update Fixed Dbafs not refreshing records cache after metadata update Mar 6, 2023
@Toflar Toflar requested a review from m-vo March 6, 2023 08:28
@leofeyer leofeyer changed the title Fixed Dbafs not refreshing records cache after metadata update Refresh the cache after updating metadata in the Dbafs class Mar 6, 2023
@leofeyer leofeyer merged commit 3adf2b2 into contao:4.13 Mar 6, 2023
@leofeyer
Copy link
Member

leofeyer commented Mar 6, 2023

Thank you @Toflar.

@Toflar Toflar deleted the fix/dbafs-metadata-cache branch March 6, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants