Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the inconsistent form field wrapper #5881

Merged
merged 1 commit into from Mar 20, 2023
Merged

Remove the inconsistent form field wrapper #5881

merged 1 commit into from Mar 20, 2023

Conversation

leofeyer
Copy link
Member

@leofeyer leofeyer commented Mar 16, 2023 •
edited

Fixes #5812

@leofeyer leofeyer added the bug label Mar 16, 2023
@leofeyer leofeyer added this to the 5.1 milestone Mar 16, 2023
@leofeyer leofeyer self-assigned this Mar 16, 2023
@leofeyer leofeyer requested a review from a team March 16, 2023 08:31
@leofeyer leofeyer linked an issue Mar 16, 2023 that may be closed by this pull request
Do not encapsulate widgets in mod_password.html5 #5812
Closed
aschempp
aschempp reviewed Mar 16, 2023
View reviewed changes
Copy link
Member

@aschempp aschempp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good but I think this should be fixed in the next minor release.

@leofeyer leofeyer changed the base branch from 5.1 to 5.x March 16, 2023 09:28
@leofeyer leofeyer changed the base branch from 5.x to 5.1 March 16, 2023 09:29
@leofeyer leofeyer changed the base branch from 5.1 to 5.x March 16, 2023 09:31
@leofeyer leofeyer modified the milestones: 5.1, 5.2 Mar 16, 2023
@leofeyer leofeyer merged commit 1690704 into contao:5.x Mar 20, 2023
16 checks passed
@leofeyer leofeyer deleted the fix/fields-wrapper branch March 20, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschempp aschempp aschempp approved these changes

@fritzmg fritzmg fritzmg approved these changes

Assignees

@leofeyer leofeyer

Labels
bug
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.

Do not encapsulate widgets in mod_password.html5
3 participants
@leofeyer @aschempp @fritzmg