Ensure that root pages are always shown in the correct order

[Toflar]

I'm having an issue with the page tree displaying the root pages in a different order for a restricted user group rather than the admins. This is because we call updateRoot() at all sorts of different places where the array is not always sorted by sorting. I've fixed this now by always ordering within updateRoot() in case there is a sorting field and we do not have any visibleRootTrails. Because if we do, it means $this->root contains an ID which is not on top-level in which case we cannot order by sorting anymore - this would result in a wrong order as well.

So if your user group has page mounts that only have root pages selected, you now always have the same order as the admins do - guaranteed.

[leofeyer]

Is there a way to reproduce the issue, so I can validate the changes?

[Toflar]

It depends on how the database returns the results. But here:

• Add 3 root pages
• Add a user group and only assign it 2 of those root pages as page mounts
• Switch between the admin user and a user assigned to that group

Either you see the order of the root pages is not the same or you don't. It depends on the order the IDs are added to root and returned from the DB in some of the Database::getParentRecords() or eliminateNestedPages() calls. That's why I put the sorting to updateRoot() - it's always correct then.

[leofeyer]

Thank you @Toflar.