Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log the bad credentials exception in the security channel #6136

Merged
merged 2 commits into from Jun 21, 2023
Merged

Log the bad credentials exception in the security channel #6136

merged 2 commits into from Jun 21, 2023

Conversation

bytehead
Copy link
Member

Fixes #5992

@bytehead bytehead added the bug label Jun 12, 2023
@bytehead bytehead added this to the 5.1 milestone Jun 12, 2023
@bytehead bytehead self-assigned this Jun 12, 2023
@bytehead bytehead force-pushed the fix/bad-credentials-log branch 3 times, most recently from 42fb1aa to 587ca0a Compare June 13, 2023 07:57
@bytehead bytehead marked this pull request as ready for review June 15, 2023 06:58
@bytehead bytehead requested review from leofeyer and a team June 15, 2023 06:59
aschempp
aschempp approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@aschempp aschempp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming we do need to log ourselves and Symfony does not automatically do that?

@leofeyer leofeyer linked an issue Jun 21, 2023 that may be closed by this pull request
How helpful is the "Bad credentials" log entry? #5992
Closed
@leofeyer leofeyer merged commit 003e5aa into contao:5.1 Jun 21, 2023
16 checks passed
@leofeyer
Copy link
Member

Thank you @bytehead.

@bytehead bytehead deleted the fix/bad-credentials-log branch June 21, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschempp aschempp aschempp approved these changes

@leofeyer leofeyer Awaiting requested review from leofeyer

Assignees

@bytehead bytehead

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How helpful is the "Bad credentials" log entry?
3 participants
@bytehead @leofeyer @aschempp