Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove entity mapping type for app bundle #6141

Merged
merged 2 commits into from Jun 16, 2023

Conversation

aschempp
Copy link
Member

Using type = 'annotation' will not work when using PHP8 attributes, but not specifying a type will use auto-detection.

@aschempp aschempp added the bug label Jun 13, 2023
@aschempp aschempp added this to the 4.13 milestone Jun 13, 2023
@aschempp aschempp requested review from m-vo and a team June 13, 2023 07:03
@aschempp aschempp self-assigned this Jun 13, 2023
Toflar
Toflar previously approved these changes Jun 13, 2023
@leofeyer
Copy link
Member

Test are still failing.

@leofeyer leofeyer merged commit 49b39e9 into contao:4.13 Jun 16, 2023
17 checks passed
@leofeyer
Copy link
Member

Thank you @aschempp.

@aschempp aschempp deleted the fix/orm-entities branch June 19, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants