Correctly encode URLs in the sitemap #6148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fritzmg
reviewed
Jun 16, 2023
fritzmg
previously approved these changes
Jun 19, 2023
ausi
reviewed
Jun 19, 2023
leofeyer
reviewed
Jun 19, 2023
Co-authored-by: Martin Auswöger <martin@auswoeger.com>
ausi
reviewed
Jun 28, 2023
Co-authored-by: Martin Auswöger <martin@auswoeger.com>
Co-authored-by: Martin Auswöger <martin@auswoeger.com>
Toflar
previously approved these changes
Jun 28, 2023
ausi
previously approved these changes
Jun 28, 2023
leofeyer
approved these changes
Jul 3, 2023
|
Thank you @aschempp. |
leofeyer
pushed a commit
that referenced
this pull request
Jul 7, 2023
leofeyer
pushed a commit
to contao/core-bundle
that referenced
this pull request
Jul 7, 2023
Description ----------- contao/contao#6148 for the sitemap event. Commits ------- 9caa73f5 Correctly encode sitemap.xml in event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URLs with ampersands are no longer correctly encoded in the new Contao sitemap controller. See isotope/core#2402
They were automatically encoded in Contao 4.9 (https://github.com/contao/contao/blob/4.9/core-bundle/src/Resources/contao/library/Contao/Automator.php#L377-L386), though I'm not exactly sure why that was so complicated 😂