Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use createElementNS for namespaced XML elements #6157

Merged
merged 15 commits into from Aug 8, 2023
Merged

Use createElementNS for namespaced XML elements #6157

merged 15 commits into from Aug 8, 2023

Conversation

ausi
Copy link
Member

@ausi ausi commented Jun 19, 2023 •
edited

WIP

See #6154

Using createElement() for namespaced elements is wrong, see https://dom.spec.whatwg.org/#ref-for-dom-document-createelement%E2%91%A0

@ausi ausi self-assigned this Jun 19, 2023
ausi added 12 commits June 19, 2023 16:12
@ausi
WIP
c13c331
@ausi
WIP
b5c1220
@ausi
WIP
323eec0
@ausi
WIP
104ebc6
@ausi
WIP
1b43c8b
@ausi
WIP
ea7434a
@ausi
WIP
5bce909
@ausi
Fix namespaced elements
0a10c0c
@ausi
Revert
5521c56 
This reverts commit 1951826.

# Conflicts:
#	core-bundle/tests/Controller/SitemapControllerTest.php
@ausi
WIP
27f5238
@ausi
WIP
9e8604b
@ausi
Fix
109bf12
@ausi ausi marked this pull request as ready for review June 20, 2023 09:29
@ausi
Copy link
Member Author

ausi commented Jun 20, 2023

This should be the final fix now.
But before merging I’d wait until a new php8.3-dev version is available on CI (should only take a couple of days).

@leofeyer leofeyer mentioned this pull request Jun 20, 2023
Closed
@ausi ausi mentioned this pull request Jun 21, 2023
Merged
@ausi
Copy link
Member Author

ausi commented Jun 21, 2023 •
edited

PHP 8.3 CI still fails, see php/php-src#11428 (comment)
not anymore 🎉

@ausi ausi requested a review from a team August 4, 2023 15:46
@leofeyer
Copy link
Member

leofeyer commented Aug 5, 2023

Should we rebase this on the 5.2 branch or even on the 5.1 one?

@leofeyer leofeyer added the CI label Aug 5, 2023
@ausi ausi changed the title Try to fix the unit tests PHP 8.3 Use createElementNS for namespaced XML elements Aug 7, 2023
@ausi
Copy link
Member Author

ausi commented Aug 7, 2023

Should we rebase this on the 5.2 branch or even on the 5.1 one?

Is not necessary I think.

I also updated the title and description of this PR as it is no longer related to the CI with PHP 8.3.

@ausi ausi added feature and removed CI labels Aug 7, 2023
@ausi ausi added this to the 5.3 milestone Aug 7, 2023
@leofeyer leofeyer merged commit 648d6e3 into contao:5.x Aug 8, 2023
16 checks passed
@leofeyer
Copy link
Member

leofeyer commented Aug 8, 2023

Thank you @ausi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leofeyer leofeyer leofeyer approved these changes

Assignees

@ausi ausi

Labels
feature
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ausi @leofeyer