Deprecate using objects that have been imported via `System::import()` #6165

leofeyer · 2023-06-22T08:02:33Z

This is the follow-up pull request to #6163.

core-bundle/contao/classes/Theme.php

bytehead

LGTM only possible CS issues remarked.

core-bundle/contao/classes/Backend.php

core-bundle/contao/widgets/MetaWizard.php

news-bundle/contao/dca/tl_news.php

faq-bundle/contao/dca/tl_faq.php

calendar-bundle/contao/dca/tl_calendar_events.php

comments-bundle/contao/dca/tl_comments.php

core-bundle/contao/dca/tl_form_field.php

comments-bundle/contao/dca/tl_comments.php

Remove the leftover BC layer in System::__get()

fbcc4f1

leofeyer added the feature label Jun 22, 2023

leofeyer added this to the 5.2 milestone Jun 22, 2023

leofeyer self-assigned this Jun 22, 2023

leofeyer commented Jun 22, 2023

View reviewed changes

core-bundle/contao/classes/Theme.php Outdated Show resolved Hide resolved

leofeyer force-pushed the feature/import branch 3 times, most recently from 986eca9 to 7bf2c47 Compare June 22, 2023 09:09

Deprecate using objects that have been imported via System::import()

c66f204

leofeyer force-pushed the feature/import branch from 7bf2c47 to c66f204 Compare June 22, 2023 09:45

leofeyer added 6 commits June 22, 2023 11:58

Replace all $this->import(BackendUser::class, 'User')

ad63e4b

Replace all $this->import(FrontendUser::class, 'User')

9b6f68d

Replace all $this->import(Automator::class, 'Automator')

5d4ecda

Replace all $this->import(Files::class, 'Files')

48d45d0

Replace all $this->import(Database::class, 'Database')

58f1b03

Replace the remaining occurrences

1561648

leofeyer force-pushed the feature/import branch from e893217 to 387cec5 Compare June 22, 2023 12:13

CS

a52dde3

leofeyer force-pushed the feature/import branch from 387cec5 to a52dde3 Compare June 22, 2023 12:20

leofeyer marked this pull request as ready for review June 22, 2023 12:23

leofeyer requested a review from a team June 22, 2023 12:24

Merge branch '5.x' into feature/import

ae872d1

Toflar mentioned this pull request Jul 3, 2023

Implement visible root trails for DC_Folder #6124

Merged

bytehead requested changes Jul 3, 2023

View reviewed changes

ausi reviewed Jul 3, 2023

View reviewed changes

comments-bundle/contao/dca/tl_comments.php Outdated Show resolved Hide resolved

ausi reviewed Jul 3, 2023

View reviewed changes

comments-bundle/contao/dca/tl_comments.php Outdated Show resolved Hide resolved

leofeyer added 2 commits July 4, 2023 11:56

Initialize the user variable outside the uksort() callback

0e96592

Do not use a $db variable if it is not re-used

21fdc95

leofeyer force-pushed the feature/import branch from 2e1427d to 21fdc95 Compare July 4, 2023 10:01

leofeyer requested a review from bytehead July 4, 2023 10:07

leofeyer requested a review from ausi July 4, 2023 10:07

bytehead approved these changes Jul 4, 2023

View reviewed changes

ausi approved these changes Jul 4, 2023

View reviewed changes

leofeyer merged commit 33c826d into contao:5.x Jul 4, 2023
16 checks passed

leofeyer deleted the feature/import branch July 4, 2023 14:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deprecate using objects that have been imported via `System::import()` #6165

Deprecate using objects that have been imported via `System::import()` #6165

leofeyer commented Jun 22, 2023 •

edited

bytehead left a comment •

edited

Deprecate using objects that have been imported via System::import() #6165

Deprecate using objects that have been imported via System::import() #6165

Conversation

leofeyer commented Jun 22, 2023 • edited

bytehead left a comment • edited

Choose a reason for hiding this comment

Deprecate using objects that have been imported via `System::import()` #6165

Deprecate using objects that have been imported via `System::import()` #6165

leofeyer commented Jun 22, 2023 •

edited

bytehead left a comment •

edited