New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decode HTML entities in feed item titles #6210
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do we need to do the same for the feed title and description here? contao/news-bundle/src/Controller/Page/NewsFeedController.php Lines 59 to 60 in e0c479f
And can we add a test case to |
ausi
previously approved these changes
Jul 13, 2023
For future reference:
|
ausi
previously approved these changes
Jul 13, 2023
aschempp
reviewed
Jul 14, 2023
aschempp
previously approved these changes
Jul 14, 2023
leofeyer
reviewed
Jul 27, 2023
leofeyer
previously approved these changes
Jul 28, 2023
leofeyer
changed the title
Decode HTML entities in feed item title
Decode HTML entities in feed item titles
Jul 28, 2023
Thank you @bezin. |
leofeyer
force-pushed
the
fix-rss-item-title-encoding
branch
from
July 28, 2023 08:27
5f4f3e7
to
594b1f2
Compare
leofeyer
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RSS spec does not mention HTML in item titles. As Contao encodes HTML entities on input, they are currently output as is in the feed item title. This PR converts them back before outputting the title to the feed.