Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the ReflectionProperty::setValue() method signature #6231

Merged
merged 1 commit into from Jul 21, 2023

Conversation

ausi
Copy link
Member

@ausi ausi commented Jul 19, 2023

Attempt to fix the CI on PHP 8.3

See php/php-src@d9a7f67

@ausi ausi added the bug label Jul 19, 2023
@ausi ausi added this to the 4.13 milestone Jul 19, 2023
@ausi ausi self-assigned this Jul 19, 2023
@ausi ausi requested a review from a team July 19, 2023 21:49
@leofeyer leofeyer merged commit 1ad8b2a into contao:4.13 Jul 21, 2023
18 checks passed
@leofeyer
Copy link
Member

Thank you @ausi.

@leofeyer leofeyer changed the title Fix ReflectionProperty::setValue() method signature Fix the ReflectionProperty::setValue() method signature Jul 21, 2023
leofeyer pushed a commit to leofeyer/contao that referenced this pull request Jul 24, 2023
Description
-----------

~~Attempt to~~ fix the CI on PHP 8.3

See php/php-src@d9a7f67

Commits
-------

94a92a6 Fix ReflectionProperty::setValue() method signature

# Conflicts:
#	core-bundle/tests/Contao/EnvironmentTest.php
#	core-bundle/tests/Contao/ModuleTest.php
#	core-bundle/tests/Contao/PageModelTest.php
#	core-bundle/tests/Framework/ContaoFrameworkTest.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants