Implement front end module permissions #6232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! 🎉 |
…to content element permissions)
|
Looks very good to me! Haven't manually tested it yet though 🙃 |
leofeyer
reviewed
Dec 29, 2023
leofeyer
reviewed
Dec 29, 2023
leofeyer
reviewed
Dec 29, 2023
leofeyer
requested changes
Dec 29, 2023
core-bundle/src/Security/Voter/DataContainer/FrontendModulesVoter.php
Outdated
Show resolved
Hide resolved
leofeyer
changed the title
leofeyer
force-pushed
the
frontend-modules-permissions
branch
from
b290fb1
to
eb11f27
Compare
leofeyer
previously approved these changes
Jan 10, 2024
leofeyer
approved these changes
Jan 10, 2024
|
Thank you @bezin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #6016: Same permission management for front-end modules as we have for content elements.
See this short video https://github.com/contao/contao/assets/4400435/b5722372-b6b7-4537-9ed5-d6ddfccfa469
Not yet finished, but I think now is the time to maybe discuss details :-)