Adjust the "preserve metadata" logic #6267
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6205
One thing is still bothering me, though: If I use a predefined image size, the preserveMetadata key stores the formats to preserve.
contao/core-bundle/tests/Image/ImageFactoryTest.php
Lines 329 to 344 in c19feca
In the
tl_image_size
table, however, the preserveMetadata key stores whether to overwrite the formats and the metadata key actually holds the formats to preserve.contao/core-bundle/tests/Image/ImageFactoryTest.php
Lines 256 to 267 in c19feca
Is this what we want?