New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use PDF TrimBox when generating previews #6276
Conversation
Looks correct to me (but I am unable to verify at the moment). |
Looks like this info was not accurate, Apple Preview uses the But I still think for our preview, the trimbox usually makes more sense, as we probably do not want to show crop marks and bleed. |
I adopted the changes to my demo installation, but it does not work. No preview is created anymore with the changes. |
@kroerig can you please post a screeshot of your changed source code? Are you using ImageMagick or GraphicsMagick? |
Yeah, got it working. Had to switch to ImageMagick and now I get nice previews. Thx a lot. |
|
@kroerig can you please check if the latest version of this pull request works for GraphicsMagick too? |
Unfortunately, I don't have Gmagick in PHP. That's why I had to switch to ImageMagick to make it work. |
I tested the changes of this PR with the PDF from https://community.contao.org/de/showthread.php?85566 on a shared hosting from Hostingwerk, which uses Gmagick. However, it does not appear to work. The preview image stays the same. |
Never mind, the changes work - I always only cleared the image cache instead of the preview cache 🙈 |
Thank you @ausi. |
AFAIK the
TrimBox
is the bounding box that most programs use for PDF previews.See https://community.contao.org/de/showthread.php?85566