Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly handle users without username in the registration module #6306

Merged
merged 1 commit into from Aug 17, 2023
Merged

Correctly handle users without username in the registration module #6306

merged 1 commit into from Aug 17, 2023

Conversation

e-spin
Copy link
Contributor

@e-spin e-spin commented Aug 16, 2023 •
edited

Update ModuleRegistration if username empty

Fix this issue terminal42/contao-mailusername#28

@github-actions github-actions bot added this to the 4.13 milestone Aug 16, 2023
@github-actions github-actions bot added the bug label Aug 16, 2023
@e-spin e-spin mentioned this pull request Aug 16, 2023
Closed
fritzmg
fritzmg approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@fritzmg fritzmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change makes sense as the code already assumes that username can be empty and thus it should also consider the case that the username key does not exist altogether.

@e-spin e-spin changed the title Update ModuleRegistration id username empty Update ModuleRegistration if username empty Aug 16, 2023
@leofeyer leofeyer changed the title Update ModuleRegistration if username empty Correctly handle users without username in the registration module Aug 17, 2023
@leofeyer leofeyer merged commit f2ed1d1 into contao:4.13 Aug 17, 2023
18 checks passed
@leofeyer
Copy link
Member

Thank you @e-spin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ausi ausi ausi left review comments

@leofeyer leofeyer leofeyer left review comments

@bytehead bytehead bytehead approved these changes

@fritzmg fritzmg fritzmg approved these changes

Assignees

@e-spin e-spin

Labels
bug
Projects
None yet
Milestone
4.13
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@e-spin @leofeyer @ausi @bytehead @fritzmg