Always set the JSON_THROW_ON_ERROR flag
#6324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leofeyer
force-pushed
the
feature/json-throw
branch
from
141fd3a
to
05d46e1
Compare
ausi
reviewed
Aug 22, 2023
ausi
reviewed
Aug 22, 2023
ausi
reviewed
Aug 22, 2023
ausi
reviewed
Aug 22, 2023
manager-bundle/src/ContaoManager/ApiCommand/SetConfigCommand.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Martin Auswöger <martin@auswoeger.com>
Co-authored-by: Martin Auswöger <martin@auswoeger.com>
ausi
previously approved these changes
Aug 23, 2023
|
|
ausi
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems like a reasonable thing to do. Any objections?