Make Symfony 6.3 the minimum version #6335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leofeyer
force-pushed
the
feature/symfony-6
branch
from
8f89361
to
80483d8
Compare
leofeyer
changed the title
ausi
previously approved these changes
Aug 25, 2023
Co-authored-by: Martin Auswöger <martin@auswoeger.com>
Co-authored-by: Martin Auswöger <martin@auswoeger.com>
|
As @aschempp pointed out in Slack, this will make it impossible for an extension to be compatible with both Contao 4.13 and 5.3, because Contao 4.13 is only compatible with Symfony 5. There are two possible solutions:
And I really hope it will not be option 2! 🤞 |
I don’t see why that should be the case. The extension simply has to use |
ausi
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.