Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the Symfony contracts #6337

Merged
merged 7 commits into from Aug 27, 2023
Merged

Conversation

leofeyer
Copy link
Member

No description provided.

@leofeyer leofeyer added this to the 5.3 milestone Aug 25, 2023
@leofeyer leofeyer self-assigned this Aug 25, 2023
composer.json Outdated Show resolved Hide resolved
@leofeyer leofeyer requested a review from a team August 25, 2023 13:12
ausi
ausi previously approved these changes Aug 25, 2023
@@ -79,7 +79,7 @@
"lcobucci/jwt": "^4.0",
"league/commonmark": "^2.2",
"league/flysystem": "^3.0",
"league/flysystem-bundle": "^2.0 || ^3.0",
"league/flysystem-bundle": "^3.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because version 2 is not installable with league/flysystem version 3.

"psr/container": "^1.0",
"psr/http-message": "^1.0",
"psr/log": "^1.0 || ^2.0 || ^3.0",
"psr/cache": "^3.0",
Copy link
Member Author

@leofeyer leofeyer Aug 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because symfony/cache-contracts version 3 is not compatible with version 1 and 2.

"psr/http-message": "^1.0",
"psr/log": "^1.0 || ^2.0 || ^3.0",
"psr/cache": "^3.0",
"psr/container": "^2.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because symfony/service-contracts version 3 is not compatible with version 1.

"psr/cache": "^3.0",
"psr/container": "^2.0",
"psr/http-message": "^1.0 || ^2.0",
"psr/log": "^1.1 || 2.0 || ^3.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version 1.0 is not installable anymore, but all other versions are.

@@ -160,7 +160,7 @@
"symfony/yaml": "^6.3",
"terminal42/escargot": "^1.4.1",
"terminal42/service-annotation-bundle": "^1.1",
"toflar/psr6-symfony-http-cache-store": "^3.0 || ^4.0",
"toflar/psr6-symfony-http-cache-store": "^4.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version 3 is not compatible with Symfony 6, therefore it is not installable anymore.

@@ -194,9 +194,7 @@
"contao/manager-plugin": "<2.0 || >=3.0",
"doctrine/annotations": "<1.9",
"doctrine/cache": "<1.10",
"friendsofsymfony/http-cache": "2.14.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our requirement is ^2.15.1, so this will never match.

"nikic/php-parser": "4.7.0",
"phpunit/phpunit": "<8.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our requirement is ^9.5.19, so this will never match.

@leofeyer leofeyer merged commit 0de4928 into contao:5.x Aug 27, 2023
16 checks passed
@leofeyer leofeyer deleted the feature/symfony-contracts branch August 27, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants