Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the "roave/better-reflection" dependency #6338

Merged
merged 2 commits into from Aug 27, 2023

Conversation

leofeyer
Copy link
Member

Apparently, we no longer use the package, so this could also be a bugfix for Contao 5.2.

@leofeyer leofeyer added this to the 5.3 milestone Aug 25, 2023
@leofeyer leofeyer self-assigned this Aug 25, 2023
@ausi
Copy link
Member

ausi commented Aug 25, 2023

Looks like I added this in #4120 by mistake?

Did you check if vendor/bin/phpunit --extensions Contao\\CoreBundle\\Tests\\PhpunitExtension\\GlobalStateWatcher still works?

ausi
ausi previously approved these changes Aug 25, 2023
Copy link
Member

@ausi ausi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was only needed for PHP versions lower than 8.1, see

// See https://github.com/php/php-src/commit/3eb97a456648c739533d92c81102cb919eab01c9
if (\PHP_VERSION_ID >= 80100) {
return [$property->hasDefaultValue(), $property->getDefaultValue()];
}

So this can be removed, yes 👍

# Conflicts:
#	composer.json
#	core-bundle/composer.json
@leofeyer leofeyer merged commit 61c2c0f into contao:5.x Aug 27, 2023
16 checks passed
@leofeyer leofeyer deleted the feature/better-reflection branch August 27, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants