Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not forward pages with parameters by default #6391

Merged
merged 7 commits into from Sep 7, 2023
Merged

Do not forward pages with parameters by default #6391

merged 7 commits into from Sep 7, 2023

Conversation

leofeyer
Copy link
Member

@leofeyer leofeyer commented Sep 6, 2023 •
edited

Fixes #488

TODO

  • Migration

@leofeyer leofeyer added the bug label Sep 6, 2023
@leofeyer leofeyer added this to the 4.13 milestone Sep 6, 2023
@leofeyer leofeyer self-assigned this Sep 6, 2023
@leofeyer leofeyer marked this pull request as draft September 6, 2023 13:12
@leofeyer @fritzmg
Fix the logic
dfc7064 
Co-authored-by: Fritz Michael Gschwantner <fmg@inspiredminds.at>
fritzmg
fritzmg reviewed Sep 6, 2023
View reviewed changes
Copy link
Contributor

@fritzmg fritzmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this with and without legacy routing, including in the presence of a getPageIdFromUrl hook and works as intended 👍

core-bundle/src/Resources/contao/languages/en/tl_page.xlf Outdated Show resolved Hide resolved
@leofeyer leofeyer marked this pull request as ready for review September 7, 2023 08:29
ausi
ausi previously approved these changes Sep 7, 2023
View reviewed changes
fritzmg
fritzmg previously approved these changes Sep 7, 2023
View reviewed changes
@leofeyer leofeyer dismissed stale reviews from fritzmg and ausi via 3a5a213 September 7, 2023 09:16
@leofeyer leofeyer merged commit be430de into contao:4.13 Sep 7, 2023
17 checks passed
@leofeyer leofeyer deleted the fix/forward-params branch September 7, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ausi ausi ausi approved these changes

@fritzmg fritzmg Awaiting requested review from fritzmg

Assignees

@leofeyer leofeyer

Labels
bug
Projects
None yet
Milestone
4.13
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leofeyer @ausi @fritzmg