Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the redirect page as page controller #6392

Merged
merged 27 commits into from Jan 12, 2024
Merged

Implement the redirect page as page controller #6392

merged 27 commits into from Jan 12, 2024

Conversation

fritzmg
Copy link
Contributor

@fritzmg fritzmg commented Sep 6, 2023

Follow up to #6390. This implements the PageRedirect page type as a page controller and thus deprecates the legacy PageRedirect class.

@fritzmg fritzmg added the feature label Sep 6, 2023
@fritzmg fritzmg added this to the 5.3 milestone Sep 6, 2023
@fritzmg fritzmg self-assigned this Sep 6, 2023
ausi
ausi previously approved these changes Sep 8, 2023
View reviewed changes
@fritzmg fritzmg mentioned this pull request Sep 9, 2023
Draft
leofeyer and others added 3 commits September 19, 2023 09:41
@leofeyer @fritzmg
Update and run the tools (see contao#6398)
e468bd9 
Description
-----------



Commits
-------

7dce19a Update and run the tools
@leofeyer @fritzmg
Update and run the tools
d804025
@fritzmg
cs fix
faf4598
aschempp
aschempp reviewed Dec 11, 2023
View reviewed changes
Copy link
Member

@aschempp aschempp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have #6596 first to generate the correct URLs for the page controllers.

There seem to be a lot of unrelated CS changes in this PR?

core-bundle/contao/config/config.php Outdated Show resolved Hide resolved
@fritzmg
Copy link
Contributor Author

fritzmg commented Dec 11, 2023 •
edited

There seem to be a lot of unrelated CS changes in this PR?

May be because of the force push from @leofeyer from 2 months ago? The unrelated changes weren't part of my original PR. // anyway, fixed now

@fritzmg
Copy link
Contributor Author

fritzmg commented Dec 11, 2023

I think we should have #6596 first to generate the correct URLs for the page controllers.

This PR is independent from that, is it not?

@fritzmg
Copy link
Contributor Author

fritzmg commented Dec 11, 2023

I think we should have #6596 first to generate the correct URLs for the page controllers.

This PR is independent from that, is it not?

Oh or did you mean for the discussion above? Then yes :)

@leofeyer
Copy link
Member

leofeyer commented Jan 2, 2024

@fritzmg Are you going to complete this PR for Contao 5.3?

@fritzmg
Copy link
Contributor Author

fritzmg commented Jan 11, 2024 •
edited

@fritzmg Are you going to complete this PR for Contao 5.3?

Currently waiting on #6596 to get merged

@fritzmg fritzmg requested review from aschempp and ausi January 11, 2024 09:07
@leofeyer leofeyer changed the title Implement redirect page as page controller Implement the redirect page as page controller Jan 12, 2024
@leofeyer leofeyer enabled auto-merge (squash) January 12, 2024 11:28
@leofeyer
Copy link
Member

Thank you @fritzmg.

@leofeyer leofeyer merged commit 4b80d47 into contao:5.x Jan 12, 2024
17 checks passed
@fritzmg fritzmg deleted the redirect-page-controller branch January 12, 2024 11:29
@aschempp aschempp mentioned this pull request Jan 26, 2024
Merged
leofeyer pushed a commit that referenced this pull request Jan 26, 2024
@aschempp
Use the content URL generator in the redirect page controller (see #6788
763dd1c 
)

Description
-----------

Follow-up to #6392

Commits
-------

73ce373 Use ContentUrlGenerator in RedirectPageController
leofeyer pushed a commit to contao/core-bundle that referenced this pull request Jan 26, 2024
@aschempp
Use the content URL generator in the redirect page controller (see #6…
8fb5397 
…788)

Description
-----------

Follow-up to contao/contao#6392

Commits
-------

73ce3730 Use ContentUrlGenerator in RedirectPageController
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leofeyer leofeyer leofeyer approved these changes

@aschempp aschempp Awaiting requested review from aschempp

@ausi ausi Awaiting requested review from ausi

Assignees

@fritzmg fritzmg

Labels
feature
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fritzmg @leofeyer @ausi @aschempp