Allow to re-use the ProcessUtil data

[Toflar]

Unfortunately, our ProcessUtil service currently cannot be used with custom flags such as -d memory_limit=-1.

You currently have to do something like this:

$process = $this->processUtil->createSymfonyConsoleProcess('...');

$reflection = new \ReflectionClass($process);
$commandline = $reflection->getProperty('commandline');
$commandline = $commandline->getValue($process);
array_splice($commandline, 1, 0, ['-d', 'memory_limit=-1']);
$process = new Process($commandline);

return $this->processUtil->createPromise($process);

First, I thought we could add a new createSymfonyConsoleProcessWithAdditonalDirectives() but then, as soon as you want to use something else than new Process() (e.g. my new new PhpSubprocess()) then this wouldn't work either.

So I thought it would be best to expose the console path and binary path as getters.

[aschempp]

how would the console path getter help in setting console arguments?

[Toflar]

The example above would now be

$process = new Process([
    $this->processUtil->getPhpBinary(),
    '-d',
    'memory_limit=-1',
    $this->processUtil->getConsolePath(),
    ...
);

return $this->processUtil->createPromise($process);

[aschempp]

so you would get the console path from the class instead of injecting the container configuration? 🤔

[Toflar]

Yes, because that's not the only thing I need.

[leofeyer]

Thank you @Toflar.