Check if $upload['tmp_name'] is set before using it
#6486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with "tmp_name" key
Toflar
requested changes
Nov 3, 2023
leofeyer
reviewed
Nov 3, 2023
Co-authored-by: Leo Feyer <1192057+leofeyer@users.noreply.github.com>
Toflar
requested changes
Nov 3, 2023
Co-authored-by: Yanick Witschi <yanick.witschi@terminal42.ch>
ausi
approved these changes
Nov 3, 2023
Toflar
approved these changes
Nov 3, 2023
So if there is no |
|
Nothing Contao has to worry about. It's just different in Contao 5 vs Contao 4.13 because in 4.13 this check happened on |
leofeyer
changed the title
$upload['tmp_name'] is set before using it
|
Thank you @qzminski. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the terminal42/contao-fineuploader extension, which provides the files as string values. The Contao form will try to cleanup the temporary files on error, which will result in a TypeError here:
/cc @Toflar