New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically translate the default maintenance template #6494
Merged
leofeyer
merged 8 commits into
contao:5.x
from
Toflar:feature/multilingual-system-maintenance-mode
Nov 14, 2023
Merged
Automatically translate the default maintenance template #6494
leofeyer
merged 8 commits into
contao:5.x
from
Toflar:feature/multilingual-system-maintenance-mode
Nov 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ausi
requested changes
Nov 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from the two small changes 👍
Co-authored-by: Martin Auswöger <martin@auswoeger.com>
Co-authored-by: Martin Auswöger <martin@auswoeger.com>
ausi
previously approved these changes
Nov 13, 2023
leofeyer
approved these changes
Nov 14, 2023
Thank you @Toflar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a solution that covers the 99% case. Most people won't adjust the maintenance template and so we can use JS to translate it according to the user's browser language if we have translations available.
So for German, this now looks like this automatically:
We might improve this even more in the future by using the upcoming Symfony translation support for JS but this is still experimental and I don't know if this is really a good fit anyway. The reason for that is that it would tie the maintenance mode to require a running system again.
I know that we are already sort of relying on the fact that the container still works as we're using Twig when using
contao:maintenance enable
. So I guess this is kind of meant to work like "in case the System does work, we can use your template, if not, then you have to copy something tovar/maintenance.html
yourself".So Twig should be fine. But using dynamic translations would probably be a bit too much.
PS: Translating the thing in the footer doesn't work because of placeholders. So this here is really KISS.