Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically translate the default maintenance template #6494

Merged

Conversation

Toflar
Copy link
Member

@Toflar Toflar commented Nov 7, 2023

Here's a solution that covers the 99% case. Most people won't adjust the maintenance template and so we can use JS to translate it according to the user's browser language if we have translations available.

So for German, this now looks like this automatically:

Bildschirmfoto 2023-11-07 um 17 24 20

We might improve this even more in the future by using the upcoming Symfony translation support for JS but this is still experimental and I don't know if this is really a good fit anyway. The reason for that is that it would tie the maintenance mode to require a running system again.
I know that we are already sort of relying on the fact that the container still works as we're using Twig when using contao:maintenance enable. So I guess this is kind of meant to work like "in case the System does work, we can use your template, if not, then you have to copy something to var/maintenance.html yourself".

So Twig should be fine. But using dynamic translations would probably be a bit too much.

PS: Translating the thing in the footer doesn't work because of placeholders. So this here is really KISS.

@Toflar Toflar added the feature label Nov 7, 2023
@Toflar Toflar added this to the 5.3 milestone Nov 7, 2023
@Toflar Toflar self-assigned this Nov 7, 2023
@Toflar Toflar requested a review from a team November 9, 2023 12:17
Copy link
Member

@ausi ausi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the two small changes 👍

core-bundle/templates/Error/service_unavailable.html.twig Outdated Show resolved Hide resolved
manager-bundle/src/Command/MaintenanceModeCommand.php Outdated Show resolved Hide resolved
@Toflar Toflar requested a review from ausi November 13, 2023 14:22
ausi
ausi previously approved these changes Nov 13, 2023
@Toflar Toflar requested a review from leofeyer November 13, 2023 22:11
@leofeyer leofeyer merged commit 3942ec6 into contao:5.x Nov 14, 2023
16 checks passed
@leofeyer
Copy link
Member

Thank you @Toflar.

@Toflar Toflar deleted the feature/multilingual-system-maintenance-mode branch December 22, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants