New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Populate contao_
Symfony translations into $GLOBALS['TL_LANG']
#6518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Another note: this also removes the |
ausi
reviewed
Nov 13, 2023
Another note: this now uses |
ausi
previously approved these changes
Nov 13, 2023
leofeyer
reviewed
Nov 21, 2023
core-bundle/tests/Fixtures/vendor/contao/test-bundle/Resources/contao/languages/en/default.xlf
Show resolved
Hide resolved
leofeyer
approved these changes
Nov 22, 2023
Thank you @fritzmg. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we cannot override
contao/languages/
translations via Symfony translations intranslations/
. Also we cannot provide labels for DCA fields via Symfony translations. Our goal is to move away from the old Contao translations in$GLOBALS['TL_LANG']
and this PR provides a first step.This PR simply populates the
$GLOBALS['TL_LANG']
array with any Symfony translations that are found within thecontao_*
translation domains. Thus you are able to override regular Contao translations in your App like this for example:And if your App or extension provides new fields for
tl_content
for example, the labels can now also be provided via Symfony translations:This makes creating translation files more comfortable when manually writing them in YAML (in case you are not using services like Transifex).
Notes:
LegacyGlobalsProcess
helper class extracts functionality that are both needed by theXliffFileLoader
andMessageCatalogue
when processing these legacy translations.tl_layout
is there due to thereset.css
etc. option values.