Use the picker to select article target in news and calendar #6551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bytehead
previously approved these changes
Nov 20, 2023
Toflar
previously approved these changes
Nov 21, 2023
leofeyer
reviewed
Nov 21, 2023
|
nope, removed in 47ea4c1 |
bytehead
approved these changes
Nov 22, 2023
|
Thank you @aschempp. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
News and calendar events currently allow to select an article target. They render a dropdown list of all articles of visible root nodes.
With this PR, the user can now use the picker to select an article, which I think is a superior interface. The only disadvantage is that one must have access to articles in the backend. We could use an callback to modify the field on-the-fly, but I'm not sure that's worth the effort?
PS: I remember having discussed this a long time ago and I was surprised this isn't implemented yet. Maybe someone remembers if I'm missing something?