Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NULL handling in the SerpPreview widget #6554

Merged
merged 2 commits into from Jan 4, 2024

Conversation

aschempp
Copy link
Member

Description (and possibily title) could be nullable fields in the database. I got the following error from calling StringUtil::substr on the value:

Deprecated: preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated

see https://terminal42.sentry.io/share/issue/fbb102c0dc534b939824576c09de1bc1/

@aschempp aschempp added the bug label Nov 23, 2023
@aschempp aschempp added this to the 4.13 milestone Nov 23, 2023
@aschempp aschempp requested a review from a team November 23, 2023 07:30
@aschempp aschempp self-assigned this Nov 23, 2023
@leofeyer leofeyer added up for discussion Issues and PRs which will be discussed in our monthly Mumble calls. and removed up for discussion Issues and PRs which will be discussed in our monthly Mumble calls. labels Dec 14, 2023
@leofeyer leofeyer changed the title Fix NULL handling in SerpPreview Fix NULL handling in the SerpPreview widget Jan 4, 2024
@leofeyer leofeyer merged commit e7bd4e9 into contao:4.13 Jan 4, 2024
17 checks passed
@leofeyer
Copy link
Member

leofeyer commented Jan 4, 2024

Thank you @aschempp.

@aschempp aschempp deleted the fix/serp-description branch January 5, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants