Backport the cache warmer test fix #6616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description ----------- The array key order is not deterministic, therefore the test failed: https://github.com/contao/contao/actions/runs/7128661169/job/19411055590 We could also solve this by adding the following code in line 173: ```php ksort($processed); foreach ($processed as &$value) { krsort($value); } ``` I don't know whether this optimizes anything other than the unit tests though. Commits ------- 2780095 Fix the cache warmer test
This was referenced Dec 10, 2023
leofeyer
approved these changes
Dec 11, 2023
Toflar
approved these changes
Dec 11, 2023
leofeyer
changed the title
|
Thank you @fritzmg. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6612 for
4.13.