Add a modern content slider element #6626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ausi
reviewed
Dec 22, 2023
core-bundle/contao/templates/twig/content_element/swiper.html.twig
Outdated
Show resolved
Hide resolved
ausi
reviewed
Dec 22, 2023
core-bundle/contao/templates/twig/content_element/swiper.html.twig
Outdated
Show resolved
Hide resolved
ausi
reviewed
Dec 22, 2023
core-bundle/contao/templates/twig/content_element/swiper.html.twig
Outdated
Show resolved
Hide resolved
Co-authored-by: Martin Ausw枚ger <martin@auswoeger.com>
leofeyer
force-pushed
the
feature/content-slider
branch
from
371cc82
to
fdf68f4
Compare
m-vo
reviewed
Dec 22, 2023
core-bundle/contao/templates/twig/content_element/swiper.html.twig
Outdated
Show resolved
Hide resolved
core-bundle/contao/templates/twig/content_element/swiper.html.twig
Outdated
Show resolved
Hide resolved
Co-authored-by: M. Vondano <m-vo@users.noreply.github.com>
ausi
previously approved these changes
Dec 28, 2023
core-bundle/contao/templates/twig/content_element/swiper.html.twig
Outdated
Show resolved
Hide resolved
ausi
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a modern content slider element now that we have nested fragments. 馃コ
To prevent naming collisions with the legacy content slider (see #6420), the new element uses a new Contao component: https://swiperjs.com
Because Swipe.js has been dead for years now, this step was long overdue.