Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the onpalette_callback #6638

Merged
merged 1 commit into from Dec 20, 2023
Merged

Conversation

aschempp
Copy link
Member

@aschempp aschempp commented Dec 19, 2023

Together with #5673 this finally allows to fine-tune the DCA view for a specific record 馃帀

Came up with this while trying to use the new nested elements, because I need to adjust the DCA based on if the current record has a parent of specific type.

@aschempp aschempp added this to the 5.3 milestone Dec 19, 2023
@aschempp aschempp requested a review from a team December 19, 2023 15:44
@aschempp aschempp self-assigned this Dec 19, 2023
@leofeyer
Copy link
Member

I don鈥榯 mind merging this, but shouldn鈥榯 we dispatch an event instead of adding a new legacy hook?

@ausi
Copy link
Member

ausi commented Dec 20, 2023

As this is not a hook but a DCA callback it should be fine I think.

@leofeyer leofeyer changed the title Added onpalette_callback Add the onpalette_callback Dec 20, 2023
@leofeyer leofeyer merged commit 9964ada into contao:5.x Dec 20, 2023
17 checks passed
@leofeyer
Copy link
Member

Thank you @aschempp.

@aschempp aschempp deleted the feature/palette-callback branch December 21, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants